Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make run-test is broken #131

Open
Gustry opened this issue Dec 4, 2017 · 0 comments
Open

make run-test is broken #131

Gustry opened this issue Dec 4, 2017 · 0 comments

Comments

@Gustry
Copy link
Contributor

Gustry commented Dec 4, 2017

Steps to reproduce

make build-test 
make run-test 

It's coming from the change from Python 2 to 3

etienne@:~/dev/osm/osm-reporter (develop) $ make build-test 

------------------------------------------------------------------
Building in test mode
------------------------------------------------------------------
Building test
Step 1/4 : FROM kartoza/osm-reporter
 ---> a2b27f26215f
Step 2/4 : RUN pip install nose nosexcover
 ---> Using cache
 ---> 053b177c99ad
Step 3/4 : ENV PYTHONPATH /reporter
 ---> Using cache
 ---> 375e3db73540
Step 4/4 : CMD nosetests -v --with-id --with-xcoverage --with-xunit --verbose --cover-package=reporter reporter
 ---> Using cache
 ---> c393b2a4ec02
Successfully built c393b2a4ec02
Successfully tagged osmreporter_test:latest
etienne@:~/dev/osm/osm-reporter (develop) $ make run-test 

------------------------------------------------------------------
Running in test mode
------------------------------------------------------------------
Starting osmreporter_db ... done
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
nose.plugins.xcover: INFO: Coverage report will include only packages: ['reporter']
nose.plugins.cover: INFO: Coverage report will include only packages: ['reporter']
#1 Failure: ImportError (No module named request) ... ERROR

======================================================================
ERROR: Failure: ImportError (No module named request)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/reporter/__init__.py", line 95, in <module>
    from reporter import views
  File "/reporter/views.py", line 21, in <module>
    from reporter.osm import (
  File "/reporter/osm.py", line 31, in <module>
    from urllib.request import urlopen
ImportError: No module named request
-------------------- >> begin captured logging << --------------------
raven.base.Client: DEBUG: Configuring Raven for host: <raven.conf.remote.RemoteConfig object at 0x7f7e62157c90>
osm-reporter: DEBUG: Sentry logging enabled
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
XML: /nosetests.xml
Name                          Stmts   Miss  Cover
-------------------------------------------------
reporter/config/__init__.py      11      0   100%
reporter/config/default.py        6      0   100%
reporter/exceptions.py            7      0   100%
reporter/metadata.py             48     41    15%
reporter/osm_node_parser.py      11      6    45%
reporter/osm_way_parser.py       51     44    14%
reporter/queries.py              28      0   100%
reporter/utilities.py           205    173    16%
-------------------------------------------------
TOTAL                           367    264    28%
----------------------------------------------------------------------
Ran 1 test in 0.005s

FAILED (errors=1)
make: *** [run-test] Error 1
etienne@:~/dev/osm/osm-reporter (develop) $ 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant