Release builds will use lto = false instead of thin
#559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* breaks x86_64-pc-windows-gnullvm target on Windows as with llvm optimization it is impossible to link clang libc++ statically. The gnullvm target is needed as it will link ucrt instead of msvc and allow running it without VC runtime. In theory it should make a fix possible for: kaspanet#417 * occasionally lead to node crashes in futures crate, especially when mixed with unsafe and C/C++ code. It is hard to reproduce, but at least with the from scratch reproduces the crash relatively often.
|
Any comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaks x86_64-pc-windows-gnullvm target on Windows as with llvm optimization it is impossible to link clang libc++ statically. The gnullvm target is needed as it will link ucrt instead of msvc and allow running it without VC runtime. In theory it should make a fix possible for: Windows: Missing VC runtime issue #417
occasionally lead to node crashes in futures crate, especially when mixed with unsafe and C/C++ code. It is hard to reproduce, but at least with the sync from scratch reproduces the crash relatively often.