[WIP] Add relative date formatting for date/datetime columns #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfnelson
changed the title
hasarindaKI
force-pushed
the
investment/type-based-index-table
branch
3 times, most recently
from
3f51e41 to
f2859e1
Compare
hasarindaKI
force-pushed
the
feature/relative-date-columns
branch
from
143803e to
c35da02
Compare
hasarindaKI
force-pushed
the
investment/type-based-index-table
branch
from
f2859e1 to
9431fad
Compare
hasarindaKI
force-pushed
the
feature/relative-date-columns
branch
2 times, most recently
from
da79b3d to
e1fe792
Compare
hasarindaKI
force-pushed
the
investment/type-based-index-table
branch
from
9431fad to
a82713a
Compare
hasarindaKI
force-pushed
the
feature/relative-date-columns
branch
2 times, most recently
from
0dbd3c8 to
a49ff73
Compare
hasarindaKI
force-pushed
the
investment/type-based-index-table
branch
from
a82713a to
040d7de
Compare
hasarindaKI
force-pushed
the
feature/relative-date-columns
branch
from
a49ff73 to
b1e8517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hasarindaKI I've pulled this out as I don't think it's close enough to ready to continue with.
The goal I had in mind was that dates and times would be relative when it's helpful, and absolute when it's not.
2 days agois helpful,260 days agois not helpful.A lot of what you've done here is already available in Rails:
ActionView::Helpers::DateHelper#distance_of_time_in_wordsI think the hard part is working out when to use that helper vs when to use absolute dates.
I've pushed a WIP commit that I hope shows my thinking about how this could work.
I think the date maths stuff should be in Koi::DateHelper – you can delete everything else there.