Test that the model instance is deleted in the destroy method #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfnelson
reviewed
Oct 16, 2024
The generated spec for the destroy method only tests the redirect, not the actual model deletion. To do this, we need to ensure that the model is instantiated before performing the action.
mattr
force-pushed
the
issue/controller-spec-does-not-test-deletion
branch
from
68f6921 to
883b206
Compare
sfnelson
approved these changes
Oct 27, 2024
|
Merged and released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated spec for the destroy method only tests the redirect, not the actual model deletion. To do this, we need to ensure that the model is instantiated before performing the action.