Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use wildcard imports + parameters naming #32

Open
mikolmogorov opened this issue Jan 21, 2023 · 0 comments
Open

Don't use wildcard imports + parameters naming #32

mikolmogorov opened this issue Jan 21, 2023 · 0 comments
Assignees

Comments

@mikolmogorov
Copy link
Collaborator

Don't use wildcard imports like from metaphase.XX import *. This makes the code difficult to read and prone to errors.

Instead, either use import metaphase.XX as YYm and then use YY.funcionZ(), or import specific functions as from metaphase.XX impot functionZ.

This in particular important for the parameters in params.py - I suggest to either use module import and then do params.PARAM_NAME or have a single dictionary with all parameters that you can import.

In addition, parameters should be given informative names (e.g. strong_cluster_min_reads, but not I or R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants