Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify way to address configuration on backend #165

Closed
3 tasks done
blcham opened this issue Nov 1, 2024 · 4 comments
Closed
3 tasks done

Unify way to address configuration on backend #165

blcham opened this issue Nov 1, 2024 · 4 comments
Assignees

Comments

@blcham
Copy link
Contributor

blcham commented Nov 1, 2024

As a developer, I would like to see configuration in application.properties unified, I see the following:

security:
  provider: internal

appContext: http://localhost:5173
oidc.RoleClaim: realm_access.roles
cors.allowedOrigins: "http://localhost:5173,http://localhost:4173"

spring.security.rolePrefix: ff-

From this fast look, I would unify it in the following way:

security:
  provider: internal
  cors.allowedOrigins: "http://localhost:5173,http://localhost:4173"  
  oidc.RoleClaim: realm_access.roles
  rolePrefix: ff-

appContext: http://localhost:5173

In case rolePrefix is specific only for oidc, I would even move it to security.oidc.rolePrefix: ff-.

A/C:

  • unify the naming convention in application.properties file
  • modify configuration in deploy/keycloak-auth and deploy/internal-auth folder
  • modify configuration in 23ava-distribution
@kostobog
Copy link
Collaborator

kostobog commented Nov 7, 2024

@blcham
Is this unification also applied to record-manager and analytics backends?
I am asking because I think I have to change this part in distribution docker-compose:

x-access-for-local-development: &local-dev-env
  cors.allowedOrigins: "http://localhost:4173,http://localhost:5173"

to this:

x-access-for-local-development: &local-dev-env
  security.cors.allowedOrigins: "http://localhost:4173,http://localhost:5173"

@blcham
Copy link
Contributor Author

blcham commented Nov 7, 2024

yes we should refactor everywhere.

@kostobog
Copy link
Collaborator

kostobog commented Nov 7, 2024

@blcham
Ready to review.
See PRs #167, kbss-cvut/fta-fmea-ui#654 and kbss-cvut/23ava-distribution#153

blcham added a commit to kbss-cvut/record-manager that referenced this issue Nov 7, 2024
@blcham
Copy link
Contributor Author

blcham commented Nov 7, 2024

blcham added a commit to kbss-cvut/record-manager-ui that referenced this issue Nov 7, 2024
blcham added a commit to kbss-cvut/record-manager-ui that referenced this issue Nov 7, 2024
blcham added a commit to kbss-cvut/record-manager that referenced this issue Nov 7, 2024
@blcham blcham closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants