Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new #56] remove items / milestones #70

Merged
merged 3 commits into from
Oct 10, 2022
Merged

[new #56] remove items / milestones #70

merged 3 commits into from
Oct 10, 2022

Conversation

PluharVit
Copy link
Collaborator

@PluharVit PluharVit commented Sep 26, 2022 •
edited by LaChope
Loading

Resolves #56

@PluharVit PluharVit requested a review from LaChope September 26, 2022 15:03
@netlify
Copy link

netlify bot commented Sep 26, 2022 •
edited
Loading

✅ Deploy Preview for react-maintenance-planner ready!

Name Link
🔨 Latest commit 0826acb
🔍 Latest deploy log https://app.netlify.com/sites/react-maintenance-planner/deploys/634415136a5d330008e749a7
😎 Deploy Preview https://deploy-preview-70--react-maintenance-planner.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

LaChope
LaChope reviewed Sep 27, 2022
View reviewed changes
src/components/PlanningTool.jsx Outdated
date: startDate
}

this.setMilestoneDefault(milestone)
this.setItemDefaults(item)
items.push(item)
// items.push(item)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not.

LaChope
LaChope approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@LaChope LaChope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just modify according to comment and you can merge

@PluharVit PluharVit merged commit b6c305d into main Oct 10, 2022
@LaChope LaChope mentioned this pull request Oct 18, 2022
Closed
@LaChope LaChope deleted the milestones branch October 18, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaChope LaChope LaChope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create / Remove milestones from UI
2 participants
@PluharVit @LaChope