Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS #104

Open
shellyear opened this issue Mar 1, 2024 · 0 comments
Open

Refactor CSS #104

shellyear opened this issue Mar 1, 2024 · 0 comments

Comments

@shellyear
Copy link
Collaborator

shellyear commented Mar 1, 2024

Hi, @blcham ! I would like to start a discussion here about CSS things that needs to be changed in the project, and that were not included as part of this merged PR

Overall styles look good, but I would like to discuss the usage of
Screenshot 2024-03-05 at 19 58 11
this font in the project (as it was initially in the project).

Also I would like to get rid of the css classes, if the project will have a tension to grow in the near future. But if the project will not grow in size(significantly), keeping styles in one css file seems to be beneficial, but I still see the need to use styled components/emotion or just LESS/SASS to organize the styles better, to make them modular. Plain css can be just used to define the very basic things like importing fonts, setting default font-size, defining color palette etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant