Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor javascript sources #98

Open
3 of 5 tasks
blcham opened this issue Feb 21, 2024 · 4 comments
Open
3 of 5 tasks

Refactor javascript sources #98

blcham opened this issue Feb 21, 2024 · 4 comments

Comments

@blcham
Copy link

blcham commented Feb 21, 2024

This is temporary collection of refactoring tasks:

  • Add prettier #106
  • Add eslint #103
  • Refactor to typescript
  • export default injectIntl(withI18n(HistoryPagination)); -- use hooks instead
  • index.html -- move var unsupportedBrowserElement, SUPPORTED_BROWSERS = ... somewhere outside
@blcham
Copy link
Author

blcham commented Feb 21, 2024

@shellyear put other stuff here

@shellyear
Copy link
Collaborator

After the migration to the vite and typescript, I suggest to use Material-UI(for CSS) and react-query(hooks for handling requests and managing data). I have prepared config for the prettier and eslint as wellr

@ledsoft
Copy link

ledsoft commented Mar 11, 2024

@blcham HistoryPagination.js (w.r.t. item 5) no longer exists, history uses the same pagination component as the records list and that one uses hooks.

@blcham
Copy link
Author

blcham commented Mar 12, 2024

@blcham HistoryPagination.js (w.r.t. item 5) no longer exists, history uses the same pagination component as the records list and that one uses hooks.

thanks, I removed it from the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants