Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in Rest API calls and refactor console logs #92

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix error handling in Rest API calls and refactor console logs #92

merged 1 commit into from
Nov 19, 2024

Conversation

palagdan
Copy link
Collaborator

Resolve #91

@palagdan palagdan requested a review from blcham November 18, 2024 13:49
blcham
blcham requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure that you are consistent when logging different errors. See my comment above.

src/components/modal/ScriptOntologyModal.jsx Outdated Show resolved Hide resolved
@palagdan palagdan force-pushed the 91-scriptpage-request-handling branch from 1379457 to 266c103 Compare November 18, 2024 15:52
@blcham
Copy link
Contributor

blcham commented Nov 18, 2024

👀

blcham
blcham requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after my one suggestion is reviewed

src/components/modal/ScriptActionsModuleModal.jsx Outdated Show resolved Hide resolved
src/components/modal/ScriptOntologyModal.jsx Outdated Show resolved Hide resolved
@palagdan palagdan force-pushed the 91-scriptpage-request-handling branch 3 times, most recently from c68d4a5 to 0191ede Compare November 19, 2024 11:00
@palagdan palagdan requested a review from blcham November 19, 2024 11:03
blcham
blcham approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blcham blcham force-pushed the 91-scriptpage-request-handling branch from 0191ede to 9f6beb7 Compare November 19, 2024 14:43
@blcham blcham merged commit c1f68f5 into master Nov 19, 2024
2 checks passed
@blcham blcham deleted the 91-scriptpage-request-handling branch November 19, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix API request error handling in Dagre ScriptPage component
2 participants
@palagdan @blcham