Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel/html files should be processed directly in tabular module #228

Open
blcham opened this issue Nov 10, 2023 · 2 comments · May be fixed by #285
Open

Excel/html files should be processed directly in tabular module #228

blcham opened this issue Nov 10, 2023 · 2 comments · May be fixed by #285
Assignees

Comments

@blcham
Copy link
Contributor

blcham commented Nov 10, 2023

In Tabular module, we transfrom HTML and Excel files into CSV and then process them using supercsv library. We need to do that directly and not transform it. In order to do that, we need to refactor the code first.

There should be a unified interface to process tabular data using (I guess) the adapter pattern. Try to do little commits to refactor it incrementally.

A/C:

@blcham blcham converted this from a draft issue Nov 10, 2023
blcham added a commit that referenced this issue Nov 10, 2023
Not complete -- tests are failing here.
blcham added a commit that referenced this issue Aug 14, 2024
Not complete -- tests are failing here.
blcham added a commit that referenced this issue Aug 14, 2024
Not complete -- tests are failing here.
blcham added a commit that referenced this issue Dec 4, 2024
Not complete -- tests are failing here.
@blcham
Copy link
Contributor Author

blcham commented Dec 4, 2024

@MSattrtand we want to keep references in the source code:

image
image

@blcham blcham assigned MSattrtand and unassigned rodionnv Dec 4, 2024
@blcham
Copy link
Contributor Author

blcham commented Dec 4, 2024

@MSattrtand BTW,

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants