Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor toString method to separate Utils Class for converting RDFNode values to the readable string #263

Closed
palagdan opened this issue Aug 20, 2024 · 3 comments · Fixed by #264
Closed

Refactor toString method to separate Utils Class for converting RDFNode values to the readable string #263

palagdan opened this issue Aug 20, 2024 · 3 comments · Fixed by #264
Assignees
@palagdan

Comments

@palagdan
Copy link
Collaborator

palagdan commented Aug 20, 2024 •
edited
Loading

Screenshot from 2024-08-19 16-21-44

Related to #76

In ticket #76, the solution addressed only the output for the VariableBindings class. In this ticket, the toString method should be refactored into a separate Utils class so that it can be used in other places.
@palagdan palagdan self-assigned this Aug 20, 2024
@palagdan
Copy link
Collaborator Author

@blcham

palagdan added a commit that referenced this issue Aug 20, 2024
@palagdan
[#263] Refactor RDFNode to string to separate utils class
75fcb0b
@palagdan palagdan mentioned this issue Aug 20, 2024
Merged
@blcham blcham reopened this Aug 21, 2024
@blcham
Copy link
Contributor

blcham commented Aug 21, 2024

Reopening this issue because I do not understand how it is related to the picture above. If merged PR was only refactoring, it should not affect the picture above. Moreover, I do not think that fixing picture above is related to code from PR.

@blcham
Copy link
Contributor

blcham commented Aug 21, 2024

We can close this issue after following comment is satisfied: #264 (comment)

palagdan added a commit that referenced this issue Aug 21, 2024
@palagdan
[#263] Revert RDFNode conversion changes
f27c1f7
blcham pushed a commit that referenced this issue Aug 21, 2024
@palagdan @blcham
[#263] Revert RDFNode conversion changes
4a74b61
@blcham blcham closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palagdan palagdan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor RDFNode to string to separate utils class kbss-cvut/s-pipes
2 participants
@blcham @palagdan