Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure failure modes are robust, expand failIfInvalidXML #29

Open
kdlong opened this issue Aug 24, 2020 · 0 comments
Open

Make sure failure modes are robust, expand failIfInvalidXML #29

kdlong opened this issue Aug 24, 2020 · 0 comments

Comments

@kdlong
Copy link
Owner

kdlong commented Aug 24, 2020

cmssw/GeneratorInterface/Core/src/LHEWeightHelper.cc

Lines 33 to 37 in 57b20d3

if (xmlError != 0) {
boost::replace_all(fullHeader, "&lt;", "<");
boost::replace_all(fullHeader, "&gt;", ">");
xmlError = xmlDoc.Parse(fullHeader.c_str());
}

This should also be captured under the failIfInvalidXML
@dteague dteague mentioned this issue Oct 13, 2020
Merged
kdlong pushed a commit that referenced this issue Sep 28, 2022
@jkiesele
Merge pull request #29 from kdlong/pepr_CMSSW_12_1_1
afa8798 
Restructure the way best match tables are stored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdlong