Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong syntax in the HTTPScaledObject in example v0.6.0 #869

Closed
yaakov-berkovitch opened this issue Dec 26, 2023 · 3 comments · Fixed by #871
Closed

Wrong syntax in the HTTPScaledObject in example v0.6.0 #869

yaakov-berkovitch opened this issue Dec 26, 2023 · 3 comments · Fixed by #871

Comments

@yaakov-berkovitch
Copy link

Report
The HTTPScaledObject example for release 0.6.0 failed to deploy

Expected Behavior
Expect that the example can be deployed without any errors.

Actual Behavior
Using the example (a good short way instead of reading the documentation) from folder example/0.6.0 returns an error:

Error from server (BadRequest): error when creating "/tmp/KK.yaml": HTTPScaledObject in version "v1alpha1" cannot be handled as a HTTPScaledObject: strict decoding error: unknown field "spec.scaleTargetRef.name"

After I looked in previous versions, I saw that "deployment" was used, and so I replaced the spec.scaleTargetRef.name by spec.scaleTargetRef.deployment and it works,

Steps to Reproduce the Problem
Deploy the HTTPScaledObject from v0.6.0 example folder

Logs from KEDA HTTP operator
N/A

What version of the KEDA HTTP Add-on are you running?
0.6.0

Kubernetes Version
1.27

Platform
AWS EKS

@tomkerkhove
Copy link
Member

I presume you are referring to https://github.com/kedacore/http-add-on/blob/main/examples/v0.6.0/httpscaledobject.yaml? I think it was accidentally using name due to 2144312#diff-3de0e1f7f6bd340346cd5323abea4cfca82dc7b8190c676cc35de61a78020e39 and should be deployment instead but @JorTurFer can verify

@JorTurFer
Copy link
Member

Oh, you are totally right, I did a mistake when I added the example. Let me open a PR to fix it

@JorTurFer
Copy link
Member

This is the fix: #871
Instead of name, use deployment

Thanks for reporting! 🙇

@github-project-automation github-project-automation bot moved this from To Triage to Done in Roadmap - KEDA HTTP Add-On Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants