Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce CloudEvent to KEDA #1227

Merged
merged 17 commits into from
Nov 23, 2023
Merged

Introduce CloudEvent to KEDA #1227

merged 17 commits into from
Nov 23, 2023

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Sep 20, 2023 •
edited by tomkerkhove
Loading

Introduce CloudEvent to KEDA

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#4968
Relates to kedacore/keda#3533

@SpiritZhou
Update
5faca74 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou SpiritZhou requested a review from a team as a code owner September 20, 2023 07:58
@netlify
Copy link

netlify bot commented Sep 20, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 5150562
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/655f02fcbe05e4000869952c
😎 Deploy Preview https://deploy-preview-1227--keda.netlify.app/docs/2.13/operate/events
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove
Copy link
Member

tomkerkhove commented Sep 21, 2023 •
edited
Loading

Given the functionality we are planning, the information we should share on how it works etc; what do you think if we use this approach for docs @zroubalik & @JorTurFer?

  • Concept page on how it works, what scenarios it enables and how it compares to Kubernetes events (CRDs to be used)
  • Operations page to list all supported events, with pointer to concept page

Concept docs should also include this/or similar view to this one:
image

@SpiritZhou
Update
8e737b5 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
0b6a1b8 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
010dc75 
Signed-off-by: SpiritZhou <[email protected]>
tomkerkhove
tomkerkhove reviewed Oct 16, 2023
View reviewed changes
content/docs/2.12/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.12/operate/events.md Outdated Show resolved Hide resolved
@tomkerkhove tomkerkhove mentioned this pull request Oct 17, 2023
Merged
6 tasks
@SpiritZhou
Update
a591e2a 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
c3b9e14 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Merge branch 'main' into spiritzhou/cloudevent
f108e2c 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Fix
709d0a4 
Signed-off-by: SpiritZhou <[email protected]>
tomkerkhove
tomkerkhove reviewed Oct 19, 2023
View reviewed changes
content/docs/2.13/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/events.md Show resolved Hide resolved
SpiritZhou and others added 5 commits October 30, 2023 09:56
@SpiritZhou @tomkerkhove
Update content/docs/2.13/operate/events.md
ae6bd9d 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @tomkerkhove
Update content/docs/2.13/operate/events.md
c549359 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @tomkerkhove
Update content/docs/2.13/operate/events.md
42cdb37 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
5f34698 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
3e2f0e3 
Signed-off-by: SpiritZhou <[email protected]>
tomkerkhove
tomkerkhove approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial changes, LGTM other than Zbynek's comment

content/docs/2.13/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/events.md Outdated Show resolved Hide resolved
@tomkerkhove
docs: Editorial changes
07fd252 
Signed-off-by: Tom Kerkhove <[email protected]>
@SpiritZhou
Fix
5150562 
Signed-off-by: SpiritZhou <[email protected]>
@tomkerkhove tomkerkhove merged commit a379450 into kedacore:main Nov 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer Awaiting requested review from JorTurFer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpiritZhou @tomkerkhove @zroubalik @JorTurFer