Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide schema for scaler configuration #2359

Open
tomkerkhove opened this issue Nov 29, 2021 · 12 comments
Open

Provide schema for scaler configuration #2359

tomkerkhove opened this issue Nov 29, 2021 · 12 comments
Labels
enhancement New feature or request feature All issues for new features that have been committed to

Comments

@tomkerkhove
Copy link
Member

tomkerkhove commented Nov 29, 2021

Provide schema for scaler configuration so that we can do diffs on PRs to detect (unwanted) breaking changes, allow community to build tooling (see #249), allow platform providers to integrate and more.

This should be automatically generated based on our Go-code, or our Go-code should be linted against it.

@tomkerkhove tomkerkhove added enhancement New feature or request help wanted Looking for support from community labels Nov 29, 2021
@joebowbeer
Copy link
Contributor

Provide json schema for use with kubeval or kubeconform?

@tomkerkhove
Copy link
Member Author

For example, yes.

@stale
Copy link

stale bot commented Mar 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Mar 5, 2022
@tomkerkhove tomkerkhove added the feature All issues for new features that have been committed to label Mar 7, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Mar 7, 2022
@tomkerkhove
Copy link
Member Author

Any thoughts on how to do it @kedacore/keda-maintainers?

@sabbour
Copy link

sabbour commented Mar 17, 2023

Interested in this.

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Jun 14, 2023

Dapr does a similar thing: https://github.com/dapr/components-contrib/blob/master/bindings/azure/servicebusqueues/metadata.yaml

We should really do this rather sooner than later as well to allow the community to build tooling for our scalers. Let me figure out how this is being generated.

@FabianTek
Copy link

Hey @tomkerkhove ,
Is there any chance this will be picked up sooner than later? I saw it on the roadmap, but what does that mean looking at the likelyhood of this being implemented?

It would really help us validating KEDA resource definitions next to basic Kubernetes resources as well as flux definitions based on their schemas

@tomkerkhove
Copy link
Member Author

We need to find a way to auto-generate the schema rather than hand-crafted.

@zroubalik @JorTurFer can we do this now after doing #5797?

@JorTurFer
Copy link
Member

I think that we will be able somehow, yes. @wozniakjan ?

@wozniakjan
Copy link
Member

I believe so, although I haven't started working on the tooling yet.

Perhaps #5797 and the tooling can be worked on in parallel. I think when the tooling is available, it would be a great incentive for contributors to refactor the scaler config parser implementations to match #5797.

@JorTurFer
Copy link
Member

I think that we can start with the tool indeed. I mean, we have already some scalers using this declarative approach, so we can do it right now and once there are more scalers supporting this approach, the docs should be updated "automatically"

@tomkerkhove
Copy link
Member Author

I believe so, although I haven't started working on the tooling yet.

Perhaps #5797 and the tooling can be worked on in parallel. I think when the tooling is available, it would be a great incentive for contributors to refactor the scaler config parser implementations to match #5797.

Totally agree!

I think that we can start with the tool indeed. I mean, we have already some scalers using this declarative approach, so we can do it right now and once there are more scalers supporting this approach, the docs should be updated "automatically"

+1, is this something you can help with @SpiritZhou? Maybe you can collaborate with @wozniakjan on this?

@tomkerkhove tomkerkhove removed their assignment Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature All issues for new features that have been committed to
Projects
Status: To Do
Development

No branches or pull requests

6 participants