Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conditional requests functionaliy with Github Scaler #6503

Closed
andrewhibbert opened this issue Jan 29, 2025 · 0 comments · Fixed by #6505
Closed

Use conditional requests functionaliy with Github Scaler #6503

andrewhibbert opened this issue Jan 29, 2025 · 0 comments · Fixed by #6505
Assignees
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@andrewhibbert
Copy link
Contributor

andrewhibbert commented Jan 29, 2025

Proposal

The best practices recommend using conditional requests and that most endpoints return and etag header and that many return a last-modified header and if you supply this in the request you get a 304 which will not count against the primary rate limit. This would reduce the impact on the rate limits for the github api

Use-Case

Reduce impact on Github API

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

@andrewhibbert andrewhibbert added feature-request All issues for new features that have not been committed to needs-discussion labels Jan 29, 2025
@JorTurFer JorTurFer moved this from To Triage to In Progress in Roadmap - KEDA Core Feb 13, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Status: Ready To Ship
Development

Successfully merging a pull request may close this issue.

1 participant