-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce CloudEvents to KEDA #4968
Conversation
Signed-off-by: SpiritZhou <[email protected]>
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
@SpiritZhou if you have some time; would you mind opening a doc PR in parallel so that we can work on the end-user experience there? |
I'm sure this is on your radar but just in case it's not - Let's make sure to add some e2e tests. For plain HTTP, I think we can use a simple client which we can verify if the event was received and echo it back |
Yes. This is a draft PR and I am adding some tests and improving coding now. |
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are doing an incredible work @SpiritZhou . Thanks a lot for that
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
652d812
to
b2ccf7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a minor stuff
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
/run-e2e cloudevent |
@SpiritZhou Is the doc PR still up to date? I'll do another review pass |
/run-e2e cloudevent |
The doc PR is up to date. And I see the e2e test failed at the keda installation process. How can I fix that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e cloudevent |
@SpiritZhou is there a charts PR for this feature? |
To be clear - Zbynek is looking for changes on configuring the default cluster name to use in events + the new CRD to be added in the chart |
@zroubalik @tomkerkhove Here is the chart PR about this feature. Could you help to review? kedacore/charts#572 |
Done! |
Docs + Helm are open and depend on this one so we should be able to merge, what do you think @zroubalik? |
The Charts PR is still not resolved 🤷♂️ |
Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Co-authored-by: Josef Karasek <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: Yoon Park <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Co-authored-by: Josef Karasek <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: anton.lysina <[email protected]>
Checklist
Relates to #3533
Relates to kedacore/keda-docs#1227
Relates to kedacore/charts#572