Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace semver with packaging #1460

Closed
1 task done
rashidakanchwala opened this issue Jul 23, 2023 · 4 comments · Fixed by #1578
Closed
1 task done

Replace semver with packaging #1460

rashidakanchwala opened this issue Jul 23, 2023 · 4 comments · Fixed by #1578
Assignees
Labels
Issue: Feature Request Python Pull requests that update Python code

Comments

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Jul 23, 2023

Description

Should we replace semver.Version with packaging.version.Version as PEP 440 versions are not exactly compatible with SemVer ?

https://peps.python.org/pep-0440/#semantic-versioning, https://packaging.pypa.io/en/stable/version.html

@astrojuanlu to provide more info.

Checklist

  • Include labels so that we can categorise your feature request
@astrojuanlu
Copy link
Member

This is a low-effort, low-gain ticket. Theoretically, there could be a Kedro version string that cannot be parsed by semver, which can nonetheless be parsed by packaging.version. The reason is that versions for Python packages uploaded to PyPI follow PEP 440, which has some incompatibilities with the SemVer spec.

More:

So, making the change is trivial, but also the advantages are mostly theoretical at this point.

@astrojuanlu
Copy link
Member

More info on the specific features of Python versioning https://sethmlarson.dev/pep-440?date=2023-08-03

@tynandebold tynandebold moved this to Inbox in Kedro-Viz Aug 14, 2023
@tynandebold
Copy link
Member

Closing this based on @astrojuanlu's comment.

@tynandebold tynandebold closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
@github-project-automation github-project-automation bot moved this from Inbox to Done in Kedro-Viz Aug 14, 2023
@rashidakanchwala
Copy link
Contributor Author

Opening this because we are using packaging now in backend so we might as well replace semver with packaging
cc - @noklam

@tynandebold tynandebold moved this from Done to Todo in Kedro-Viz Oct 2, 2023
@ravi-kumar-pilla ravi-kumar-pilla self-assigned this Oct 12, 2023
@ravi-kumar-pilla ravi-kumar-pilla moved this from Todo to In Progress in Kedro-Viz Oct 12, 2023
@tynandebold tynandebold added the Python Pull requests that update Python code label Oct 16, 2023
@ravi-kumar-pilla ravi-kumar-pilla moved this from In Progress to In Review in Kedro-Viz Oct 16, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request Python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants