Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor make version to automatically bump the version without depending on the argument #1486

Closed
ravi-kumar-pilla opened this issue Aug 14, 2023 · 1 comment
Labels
Enhancement Python Pull requests that update Python code Testing

Comments

@ravi-kumar-pilla
Copy link
Contributor

Currently, to prepare a release branch we accept an argument VERSION by running -

make version VERSION=<version-to-release>

This updates the versions in the below files -

  • VIZ_INIT_FILE
  • PACKAGE_JSON_FILE
  • PACKAGE_JSON_LOCK_FILE
  • DEMO_VERSION_FILE

Instead of depending on developers input for version, we can -

  1. Get the latest version published in pypi
  2. Bump the semantic version without depending on the passed argument
  3. Update the version in the files above

Questions -

Currently we do not update the package version here in package-lock.json. Should we do that ?

 "packages": {
    "": {
      "name": "@quantumblack/kedro-viz",
      "version": "6.3.3",
@ravi-kumar-pilla ravi-kumar-pilla converted this from a draft issue Aug 14, 2023
@ravi-kumar-pilla ravi-kumar-pilla added Enhancement Python Pull requests that update Python code Testing labels Aug 14, 2023
@ravi-kumar-pilla
Copy link
Contributor Author

Closing this as we need more control on minor, major and patch releases

@github-project-automation github-project-automation bot moved this from Todo to Done in Kedro-Viz Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Python Pull requests that update Python code Testing
Projects
Status: Done
Development

No branches or pull requests

1 participant