Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fastapi so that pydantic v2 is supported #1532

Closed
IngerMathilde opened this issue Sep 18, 2023 · 2 comments
Closed

Bump fastapi so that pydantic v2 is supported #1532

IngerMathilde opened this issue Sep 18, 2023 · 2 comments
Labels
Community Dependencies Pull requests that update a dependency file Python Pull requests that update Python code

Comments

@IngerMathilde
Copy link

Description

Update fastapi so that pydantic v2 is supported.

Context

Currently our new projects want to be able to use pydantic v2 for performance reason. However, this conflicts with kedro-viz, as they depend on fastapi <0.1 which depends on pydantic v1. The frustrating thing that this is not a problem for kedro runs, just for visualizing with pythonic kedro-viz. I suppose we could use the react standalone application, but this seems quite an overhead.

Possible Implementation

A new version using the new fastapi which supports pydantic v2, (is annoying as you have to keep two versions alive, legacy and new application)

Possible Alternatives

Make the python version standalone? So that it does not try to implement a session? No clue how it would work exactly.

Checklist

  • Python
@tynandebold tynandebold moved this to Backlog in Kedro-Viz Sep 18, 2023
@tynandebold tynandebold added Dependencies Pull requests that update a dependency file Python Pull requests that update Python code Community and removed Issue: Feature Request labels Sep 18, 2023
@tynandebold tynandebold linked a pull request Sep 18, 2023 that will close this issue
5 tasks
@IngerMathilde
Copy link
Author

Ah thanks did not see that a pull request was active

@tynandebold
Copy link
Member

Closing this in favor of #1529

@tynandebold tynandebold closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Kedro-Viz Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Dependencies Pull requests that update a dependency file Python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants