Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear dataset type #2071

Closed
1 task
astrojuanlu opened this issue Sep 2, 2024 · 2 comments
Closed
1 task

Unclear dataset type #2071

astrojuanlu opened this issue Sep 2, 2024 · 2 comments
Assignees
@SajidAlamQB
Labels
Hacktoberfest Issues to be completed during Hacktoberfest Issue: Bug Report Quick Win Low/Medium priorities but quick to do

Comments

@astrojuanlu
Copy link
Member

Description

If I have a polars.CSVDataset and a pandas.CSVDataset, both display just CSVDataset on the sidebar.

Context

How has this bug affected you? What were you trying to accomplish?

Steps to Reproduce

  1. kedro new --name=kedro-preview --tools=viz,data --example=y
  2. Replace one of the datasets with polars.CSVDataset and install `kedro-datasets[polars]
  3. kedro viz run

Expected Result

I expected to see the full dataset qualifier.

Actual Result

I see only the class name.

image

(no preview because it's not a pandas dataset)

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • Web browser system and version:
  • Operating system and version:
  • NodeJS version used (if relevant):
  • Kedro version used (if relevant):
  • Python version used (if relevant):

Checklist

  • Include labels so that we can categorise your issue
@rashidakanchwala
Copy link
Contributor

this should be a quick fix.

@rashidakanchwala rashidakanchwala added the Quick Win Low/Medium priorities but quick to do label Sep 23, 2024
@rashidakanchwala rashidakanchwala added the Hacktoberfest Issues to be completed during Hacktoberfest label Oct 7, 2024
@SajidAlamQB SajidAlamQB mentioned this issue Oct 10, 2024
Merged
5 tasks
@SajidAlamQB SajidAlamQB self-assigned this Oct 10, 2024
@SajidAlamQB
Copy link
Contributor

Completed in: #2136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SajidAlamQB SajidAlamQB

Labels
Hacktoberfest Issues to be completed during Hacktoberfest Issue: Bug Report Quick Win Low/Medium priorities but quick to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@astrojuanlu @Huongg @rashidakanchwala @SajidAlamQB