-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide simple mechanism for adding icons to datasets #480
Comments
I'm going to reopen this - since users on Dicsord have been asking for the same thing |
Such a feature would be nice, not only at the dataset level, but also at the node level. Personally when I make pipelines with kedro i try to make nodes responsible for only one main activity (that can be clearly explained to others). It would be nice to represent each node in kedro viz with an icon summarizing the main task the node is doing. e.g. clean, stack, join, filter, train, predict.. And naturally as you said in the issue title, it can be also interesting to identify the dataset types based on their icon, giving a hint to a data source origin : csv, sql, excel file, as a pipeline is often a mix of various dataset types.. Possibilities are quite numerous if a good icon collection can be provided! |
I would second this. Could help keep the pipeline maintainer right as well as improve comprehension among a non-technical audience. It should go without saying that it should not be compulsory, however. Perhaps could be toggled in Viz. To play devil's advocate, I would also say that the wrong implementation could add unnecessary complexity. I think it's a great idea, but only with the right design choices. Users frequently say they like Kedro because it's opinionated, so whatever the implementation is, it should be congruent with that broader ethos. That's my two pence anyways! |
We do support this pattern already for image datasets on Kedro so users can differentiate images and know to click on them. It would be great to infer which icons to use based on what Kedro dataset was chosen so that we reduce complexity for end users and so they won't have to spend a lot of time digging through an icon pack figuring out what icon to use. For now we've marked this as a minor priority because our current scope of work consists of working on experiment tracking and increasing the general adoption of Viz. |
I like this idea although agree it's not a high priority. In terms of implementation, to me this is part of a more general question about how to add custom properties to datasets. In this case it actually goes beyond just datasets since @nicolasboisseau said you might like to add an icon to a node, which could obviously not be done by adding a new attribute in catalog.yml. But the question of custom attributes for datasets keeps coming up and we should figure it out. It's particularly relevant for kedro-viz but really a more general kedro problem. My comment from #907:
Also, just for completeness, I mooted the idea of a new viz.yml configuration file in #903 and #907. This is probably the right approach for the implementation here since it would cater for datasets and nodes. In practical terms, solving the question of custom properties is also quickest and easiest to do on the kedro-viz side without needing a general kedro solution which might take a long time. |
I'm going to close this again. We're considering an idea in which we give a more robust set of icons based on datasets and the like, though not anything that could ever be chosen by users. See here #1148. |
ContextThis feature request was also an output from the Kedro-Viz adoption synthesis #987 Users want to be able to tag datasets, and these tags are inherited by the node. This would allow their team to then tag in the catalog, and then the data scientists can understand better where certain datasets with these tags flow. Supporting quotes
|
Description
Users can label their dataset in the catalog and provide layers - but there is very little they can do to differentiate datasets beyond this from a visual perspective. Adding the facility to apply an icon from an existing library of icons would be an effective mechanism for making the pipeline visualisation a clearer and more efficient story-telling tool.
Context
A simple example for where this would be useful would be to allow users to mark Excel datasources vs SQL datasources at a glance, even more so in the collapsed label-less view.
Possible Implementation
On the YAML catalog side there could be an extra key for
icon
like so:This could pull in the following icon from the Carbon design system (by IBM): provided by the
iconfiy
framework which collects several open source icon libraries.https://iconify.design/icon-sets/carbon/csv.html
By using the
[iconfiy-react](https://github.com/iconify/iconify-react)
library this would hopefully be a low effort additionChecklist
The text was updated successfully, but these errors were encountered: