-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pandas and plotly dependency #999
Comments
More context: if we implement #907 then Pandas may become a dependency we need to keep around. |
@tynandebold Just to emphasise the may on the above point - this depends very much on where the preview implementation ends up (kedro-datasets side vs. kedro-viz side). If we do end up needing |
Makes sense. Should we remove Pandas as well as Plotly now then? Or wait until we implement comparing metrics, as you said here?
|
On second thoughts I don't think we need to wait for that actually, because we can always add the plotly/pandas dependency back in if we do require it. And I think we should work hard to try to avoid requiring it (should be possible). What this does depend on though is what we do with #1000:
Overall I'm inclined to go for the 1st option. |
Yes, I think we can remove the dependencies if we show the plot in d3 as discussed here #1000 We might need to add it back when we work on dataset preview (as we will mostly be doing the reading in Kedro-viz) but if we are going to save all the rows in a DB then we might not even need it. So it makes sense to remove it for now. |
Currently kedro-viz has these requirements which ideally shouldn't be necessary:
These are only used in
flowchart.DataNodeMetadata.create_metrics_plot
for generating the metrics plot in the metadata panel. The reason they shouldn't be required is that they are used for very simple data wrangling, which we should be able to handle without much obfuscation by using purely Python dictionary ➡️ reshape as necessary ➡️ pure json (should not even need any particular plotly syntax) ➡️ make plot on frontend.The text was updated successfully, but these errors were encountered: