Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix
kedro viz --load-file
to run from any directory without requiring a Kedro project #2206Fix
kedro viz --load-file
to run from any directory without requiring a Kedro project #2206Changes from 16 commits
65041c4
242f35b
a9aca8a
2b722cf
c68feb4
c63991e
bc9c6c1
cc8a0cc
d905f15
127b17c
9ad595a
6134de1
fadf23b
ef69013
9d72f17
7480778
656dfdb
c20d8d8
7d3fc20
8d7dafc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 167 in docs/source/cli-docs.md
GitHub Actions / vale
[vale] docs/source/cli-docs.md#L167
Raw output
Check warning on line 167 in docs/source/cli-docs.md
GitHub Actions / vale
[vale] docs/source/cli-docs.md#L167
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey I'm thinking maybe this
kedro_project_path
does not need to be defined outside the if-else statement if it is only used within the else block?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is needed later, it is passed to run_server