Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kedro-catalog JSON schema to kedro-datasets #4258

Closed
ianwhale opened this issue Oct 25, 2024 · 3 comments
Closed

Move kedro-catalog JSON schema to kedro-datasets #4258

ianwhale opened this issue Oct 25, 2024 · 3 comments
Labels
good first issue Good first issues for beginners Issue: Feature Request New feature or improvement to existing feature

Comments

@ianwhale
Copy link
Contributor

Description

Summary here is:

  • Datasets have moved, so it seems like this file should too.
  • Workflow for adding new datasets will be more seamless with the file living with kedro-datasets.

See more on the origin of this issue here: #4196.

Context

Alleviate maintenance burden by having these schema live with the datasets themselves.

Possible Implementation

  • Move it on over!
  • Add clause on "update json schema if necessary" to PR template.

Possible Alternatives

None considered!
@ianwhale ianwhale added the Issue: Feature Request New feature or improvement to existing feature label Oct 25, 2024
@datajoely
Copy link
Contributor

I would add that it might be time to explore automatic generation through introspection and avoid the manual maintenance element

@ianwhale
Copy link
Contributor Author

If only Hacktober had more time! That would be a fun little project.

Great idea Joel!

@noklam noklam added Hacktoberfest Issue suitable for hacktoberfest good first issue Good first issues for beginners labels Oct 27, 2024
@github-actions github-actions bot mentioned this issue Nov 1, 2024
Closed
@noklam noklam mentioned this issue Nov 4, 2024
Closed
@merelcht merelcht removed the Hacktoberfest Issue suitable for hacktoberfest label Nov 26, 2024
chrisschopp added a commit to chrisschopp/kedro that referenced this issue Dec 1, 2024
@chrisschopp
Move kedro-catalog JSON schema to kedro-datasets kedro-org#4258
0a37127 
Signed-off-by: Chris Schopp <[email protected]>
This was referenced Dec 1, 2024
Merged
Merged
@chrisschopp chrisschopp mentioned this issue Dec 12, 2024
Open
@ravi-kumar-pilla ravi-kumar-pilla mentioned this issue Jan 6, 2025
Open
7 tasks
merelcht added a commit that referenced this issue Jan 22, 2025
@chrisschopp @merelcht @astrojuanlu
Move kedro-catalog JSON schema to kedro-datasets (#4359)
46259b9 
* Move `kedro-catalog` JSON schema to `kedro-datasets` #4258

Signed-off-by: Chris Schopp <[email protected]>

* Add description of change to `RELEASE.md`

Signed-off-by: Chris Schopp <[email protected]>

* Update refs to `jsonschema` to use `kedro-plugins/kedro-datasets/`

Signed-off-by: GitHub <[email protected]>

* Update ignore-names.txt

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Update ignore.txt

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Keep jsonschemas for CachedDataset, MemoryDataset, and LambdaDataset

* These datasets remain in Kedro and were not moved to kedro-datasets

Signed-off-by: GitHub <[email protected]>

* Fix linter

Signed-off-by: Merel Theisen <[email protected]>

---------

Signed-off-by: Chris Schopp <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Co-authored-by: Merel Theisen <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Merel Theisen <[email protected]>
@merelcht
Copy link
Member

This was completed in #4359 and kedro-org/kedro-plugins#952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issues for beginners Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ianwhale @noklam @datajoely @merelcht