Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in plugin.md #3045

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Fix typo in plugin.md #3045

merged 3 commits into from
Sep 19, 2023

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Sep 18, 2023

Signed-off-by: Nok [email protected]
Follow up on #3013, close #1940.

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok <[email protected]>
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@noklam noklam enabled auto-merge (squash) September 19, 2023 10:08
@noklam
Copy link
Contributor Author

noklam commented Sep 19, 2023

Ping @astrojuanlu

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve because now the code looks more similar to what we had before and to what I expected, but I had not tested the version with . and I haven't tested this one, mind you

@noklam noklam merged commit 7092758 into main Sep 19, 2023
11 checks passed
@noklam noklam deleted the fix/3013-fix-typo branch September 19, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the LIFO order in which hooks are executed in settings.py
3 participants