Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于代码中的几点建议 #4

Open
Hiboboo opened this issue Jun 4, 2017 · 0 comments
Open

关于代码中的几点建议 #4

Hiboboo opened this issue Jun 4, 2017 · 0 comments

Comments

@Hiboboo
Copy link

Hiboboo commented Jun 4, 2017

1，在Android中的模型中，所有的成员变量为什么不使用public做修饰？是不是应该放弃private同时也放弃J2EE带过来的getter & setter方法；
2，我看到你在ApiImpl类中，声明了private final static String APP_KEY = ""; 这里我觉得private和static有重复嫌疑，可以去掉static的修饰以减轻内存压力；
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Hiboboo