Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished Auth? #5

Open
keely-lee opened this issue Jun 9, 2020 · 1 comment
Open

Finished Auth? #5

keely-lee opened this issue Jun 9, 2020 · 1 comment

Comments

@keely-lee
Copy link
Owner

Hi, I think I'm done with the first MVP. Can I have a review when you get the chance? I think I made the needed modifications for design docs review #3, and I worked on almost all the edits of sample state.

Thank you,
Keely

@rlim92
Copy link

rlim92 commented Jun 10, 2020

Hey Keely! Attention to detail is great! Some changes:

  • the signin/signup buttons are bolder than the real site
  • there are a good amount of dead links, you will eventually have to take a lot of them out
  • at the footer change some of the non-relevant info to be links or information about you, the creator.
  • if a field is empty on the form for sign in it renders a little message below, make sure to add this.
  • the error renders need styling
  • on the sign up form, removing the header showing multiple steps for now, until you implement a multi-step form may be a better choice
  • make sure the errors that render for the sign up form are bulleted and red.

Overall, really great work, especially the attention to detail on css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants