Fix broken unit tests

keep-network · Mar 14, 2024 · 029b974 · 029b974
1 parent dc7c78f
commit 029b974
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 23 deletions.
diff --git a/typescript/src/lib/ethereum/bridge.ts b/typescript/src/lib/ethereum/bridge.ts
@@ -57,7 +57,10 @@ export class EthereumBridge
   extends EthersContractHandle<BridgeTypechain>
   implements Bridge
 {
-  constructor(config: EthersContractConfig, chainId: Chains.Ethereum) {
+  constructor(
+    config: EthersContractConfig,
+    chainId: Chains.Ethereum = Chains.Ethereum.Local
+  ) {
     let deployment: EthersContractDeployment
 
     switch (chainId) {

diff --git a/typescript/src/lib/ethereum/tbtc-token.ts b/typescript/src/lib/ethereum/tbtc-token.ts
@@ -23,7 +23,10 @@ export class EthereumTBTCToken
   extends EthersContractHandle<TBTCTypechain>
   implements TBTCToken
 {
-  constructor(config: EthersContractConfig, chainId: Chains.Ethereum) {
+  constructor(
+    config: EthersContractConfig,
+    chainId: Chains.Ethereum = Chains.Ethereum.Local
+  ) {
     let deployment: EthersContractDeployment
 
     switch (chainId) {

diff --git a/typescript/test/lib/ethereum.test.ts b/typescript/test/lib/ethereum.test.ts
@@ -5,7 +5,6 @@ import {
   EthereumBridge,
   EthereumTBTCToken,
   ethereumAddressFromSigner,
-  ethereumNetworkFromSigner,
   Hex,
 } from "../../src"
 import {
@@ -691,22 +690,4 @@ describe("Ethereum", () => {
       })
     })
   })
-
-  describe("ethereumNetworkFromSigner", () => {
-    context("when the signer is a wallet", () => {
-      const [mockSigner] = new MockProvider().getWallets()
-      it("should return the signer's network", async () => {
-        expect(await ethereumNetworkFromSigner(mockSigner)).to.be.eql("local")
-      })
-    })
-
-    context("when the signer is a provider", () => {
-      const mockProvider = getDefaultProvider()
-      it("should return the signer's network", async () => {
-        expect(await ethereumNetworkFromSigner(mockProvider)).to.be.eql(
-          "mainnet"
-        )
-      })
-    })
-  })
 })
diff --git a/typescript/test/services/deposits.test.ts b/typescript/test/services/deposits.test.ts
@@ -22,6 +22,7 @@ import {
   DepositsService,
   EthereumAddress,
   extractBitcoinRawTxVectors,
+  L2Chain,
 } from "../../src"
 import { MockBitcoinClient } from "../utils/mock-bitcoin-client"
 import { MockTBTCContracts } from "../utils/mock-tbtc-contracts"
@@ -1620,7 +1621,12 @@ describe("Deposits", () => {
       let depositService: DepositsService
 
       beforeEach(async () => {
-        depositService = new DepositsService(tbtcContracts, bitcoinClient)
+        depositService = new DepositsService(
+          tbtcContracts,
+          bitcoinClient,
+          // Mock cross-chain contracts resolver.
+          (_: L2Chain) => undefined
+        )
       })
 
       context("when default depositor is not set", () => {
@@ -1801,7 +1807,12 @@ describe("Deposits", () => {
       let depositService: DepositsService
 
       beforeEach(async () => {
-        depositService = new DepositsService(tbtcContracts, bitcoinClient)
+        depositService = new DepositsService(
+          tbtcContracts,
+          bitcoinClient,
+          // Mock cross-chain contracts resolver.
+          (_: L2Chain) => undefined
+        )
       })
 
       context("when active wallet is not set", () => {