Suppress Slither's false positives

keep-network · Feb 21, 2024 · d3cc2e8 · d3cc2e8
1 parent 584c4bb
commit d3cc2e8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/solidity/contracts/bridge/RedemptionWatchtower.sol b/solidity/contracts/bridge/RedemptionWatchtower.sol
@@ -32,6 +32,7 @@ import "./Redemption.sol";
 ///         requester while inflicting a freeze and financial penalty on the
 ///         amount. The goal of this penalty is to introduce a cost that guards
 ///         against repeated malicious redemption requests.
+// slither-disable-next-line missing-inheritance
 contract RedemptionWatchtower is OwnableUpgradeable {
     struct VetoProposal {
         // Address of the redeemer that requested the redemption.
@@ -217,6 +218,7 @@ contract RedemptionWatchtower is OwnableUpgradeable {
     function disableWatchtower() external {
         require(watchtowerEnabledAt != 0, "Not enabled");
 
+        // slither-disable-next-line incorrect-equality
         require(watchtowerDisabledAt == 0, "Already disabled");
 
         require(
@@ -403,11 +405,20 @@ contract RedemptionWatchtower is OwnableUpgradeable {
             return 0;
         }
 
-        if (objectionsCount == 0) {
+        if (
+            // slither-disable-next-line incorrect-equality
+            objectionsCount == 0
+        ) {
             return defaultDelay;
-        } else if (objectionsCount == 1) {
+        } else if (
+            // slither-disable-next-line incorrect-equality
+            objectionsCount == 1
+        ) {
             return levelOneDelay;
-        } else if (objectionsCount == 2) {
+        } else if (
+            // slither-disable-next-line incorrect-equality
+            objectionsCount == 2
+        ) {
             return levelTwoDelay;
         } else {
             revert("No delay for given objections count");

diff --git a/solidity/contracts/bridge/WalletProposalValidator.sol b/solidity/contracts/bridge/WalletProposalValidator.sol
@@ -615,6 +615,7 @@ contract WalletProposalValidator {
             uint32 minAge = REDEMPTION_REQUEST_MIN_AGE;
             if (redemptionWatchtower != address(0)) {
                 // Check the redemption delay enforced by the watchtower.
+                // slither-disable-next-line calls-loop
                 uint32 delay = IRedemptionWatchtower(redemptionWatchtower)
                     .getRedemptionDelay(redemptionKey);
                 // If the delay is greater than the usual minimum age, use it.

diff --git a/solidity/test/bridge/WalletProposalValidator.test.ts b/solidity/test/bridge/WalletProposalValidator.test.ts
@@ -3,7 +3,6 @@ import { ethers, helpers } from "hardhat"
 import chai, { expect } from "chai"
 import { FakeContract, smock } from "@defi-wonderland/smock"
 import { BigNumber, BigNumberish, BytesLike } from "ethers"
-import { arch } from "node:os"
 import type {
   Bridge,
   IRedemptionWatchtower,