Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Validate coinbase input script (BIP-34) #109

Closed
m-kus opened this issue Aug 27, 2024 · 11 comments
Closed

[feat] Validate coinbase input script (BIP-34) #109

m-kus opened this issue Aug 27, 2024 · 11 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@m-kus
Copy link
Collaborator

m-kus commented Aug 27, 2024

Check its size bounds and ensure it starts with the current block height.

Read more:

@m-kus m-kus added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 27, 2024
@od-hunter
Copy link
Contributor

od-hunter commented Aug 27, 2024

Can I work on this please @m-kus , please I’d love to be given the opportunity to contribute here.

Copy link

onlydustapp bot commented Aug 27, 2024

Hey @od-hunter!
Thanks for showing interest.
We've created an application for you to contribute to Raito - Bitcoin ZK Client.
Go check it out on OnlyDust!

@ShantelPeters
Copy link

Can I please be assigned to this issue?

Copy link

onlydustapp bot commented Aug 27, 2024

Hey @ShantelPeters!
Thanks for showing interest.
We've created an application for you to contribute to Raito - Bitcoin ZK Client.
Go check it out on OnlyDust!

@od-hunter
Copy link
Contributor

Thank you ser!

@m-kus
Copy link
Collaborator Author

m-kus commented Aug 31, 2024

How is the progress @od-hunter ? Do you need help with this task?

@maciejka maciejka added this to the Milestone 2 milestone Sep 2, 2024
@maciejka
Copy link
Collaborator

maciejka commented Sep 2, 2024

@od-hunter what is the status of the issue? We would like to complete all open Milestone 2 issues this week. Do need need any help?

@od-hunter
Copy link
Contributor

Sorry sir @maciejka , I’m on it already. I’ll push a pr soon please

@od-hunter
Copy link
Contributor

@maciejka @m-kus How do I check for the amount of bytes the script sig contains since the script sig is a type ByteArray

@m-kus
Copy link
Collaborator Author

m-kus commented Sep 3, 2024

ByteArray has len() method

@m-kus
Copy link
Collaborator Author

m-kus commented Sep 9, 2024

Resolved by #135

@m-kus m-kus closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants
@maciejka @m-kus @od-hunter @ShantelPeters and others