Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the create starknet account logic for Kotlin #76

Merged

Conversation

Gerson2102
Copy link
Contributor

Adding the create starknet account logic for Kotlin. I have an error currently. I will give more details inside of the PR.

@Gerson2102
Copy link
Contributor Author

Gerson2102 commented Sep 11, 2024

This is the error, it seems related to the RPC. But I'm not sure:
image

The RPC that I'm using is katana.

@trbutler4
Copy link
Collaborator

trbutler4 commented Sep 12, 2024

This is the error, it seems related to the RPC. But I'm not sure: image

The RPC that I'm using is katana.

Android is blocking http. You can try using a provider like alchemy, which will give you a free https starknet rpc for the time being. Alternatively you can add the katana url as an allowed url by following option 2b in this guide: https://www.geeksforgeeks.org/android-cleartext-http-traffic-not-permitted/ , or just allow all http traffic with option 1b. However we dont want to commit 1b.

@Gerson2102
Copy link
Contributor Author

Gerson2102 commented Sep 12, 2024

This is the error, it seems related to the RPC. But I'm not sure: image
The RPC that I'm using is katana.

Android is blocking http. You can try using a provider like alchemy, which will give you a free https starknet rpc for the time being. Alternatively you can add the katana url as an allowed url by following option 2b in this guide: https://www.geeksforgeeks.org/android-cleartext-http-traffic-not-permitted/ , or just allow all http traffic with option 1b. However we dont want to commit 1b.

Got it. I already did all that stuff. But still not working. Maybe I should change the RPC, do you have that RPC from Alchemy or how can I get that?

Really weird that still not working. I have Katana running on the background.

@Gerson2102
Copy link
Contributor Author

Now its working:
image
I just put a different address, from 0.0.0.0 to 10.0.2.2.

@trbutler4
Copy link
Collaborator

@Gerson2102 Looks good, can you take a look at the conflicts please?

@Gerson2102 Gerson2102 force-pushed the create-account-kotlin branch from ee2ef14 to a96ee3a Compare September 15, 2024 00:28
@@ -65,6 +65,10 @@ android {
}
dependencies {

implementation("com.swmansion.starknet:starknet:0.12.1@aar"){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a duplicate, either remove this or line 100.

@trbutler4
Copy link
Collaborator

Other than change i requested this is a good start. Will merge once that is addressed

@trbutler4
Copy link
Collaborator

actually i will just merge and then remove it.

@trbutler4 trbutler4 merged commit 99ffc4c into keep-starknet-strange:main Sep 15, 2024
1 check failed
@Gerson2102
Copy link
Contributor Author

Gerson2102 commented Sep 15, 2024

Thanks, yesterday I was deleting that dependency but for a reason I couldn't run the app again. And I was trying again today and same story. @trbutler4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants