-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add interfaces for each abstract contract used by the Starknet core contract #4
Comments
i would like to do this one :) |
@Tidus91 all yours! |
Tidus91
added a commit
to Tidus91/zaun
that referenced
this issue
Dec 25, 2023
EvolveArt
pushed a commit
that referenced
this issue
Dec 27, 2023
byteZorvin
pushed a commit
to byteZorvin/zaun
that referenced
this issue
Sep 18, 2024
…r_refactor refactor to workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Starknet core contract is a contract deployed on Ethereum.
It is made of multiple abstract contracts, the list is defined here:
zaun/lib/starknet/Starknet.sol
Line 33 in 895b35f
Those abstract contract types, define interfaces with a list of methods callable on the contract. Some are internal, but others are
external
,view
,pure
, andpayable
, meaning that they can be triggered by transactions coming from the outer world.We want our client to expose all of those.
I added some of them in #3. There is more to be added, just follow the way I did it: one abstract contract -> one file -> one
abigen
macro -> one trait -> one impl forAsRef<MyInterfaceType>
-> one field in the client -> one imp ofAsRef<MyInterfaceType> for MyClientType
.So go into each abstract contract, find the public method by hitting crtl+F, copy paste their signature in the
abigen
and then go with the flowThe text was updated successfully, but these errors were encountered: