Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACTS] implement initiate_liquidity_retrival tests #84

Closed
0xChqrles opened this issue Sep 23, 2024 · 6 comments
Closed

[CONTRACTS] implement initiate_liquidity_retrival tests #84

0xChqrles opened this issue Sep 23, 2024 · 6 comments
Assignees
Milestone

Comments

@0xChqrles
Copy link
Contributor

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

@mubarak23
Copy link
Contributor

mubarak23 commented Sep 23, 2024

@0xChqrles am available to work on this .

I am a Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project

My recent work with cairo starknet

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @mubarak23!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Oshioke-Salaki
Copy link

Please can I do this @0xChqrles

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Oshioke-Salaki!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@leohscl
Copy link
Contributor

leohscl commented Sep 24, 2024

Hey can I do this one ? @0xChqrles

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @leohscl!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

leohscl added a commit to leohscl/zkramp that referenced this issue Sep 26, 2024
 [CONTRACTS] implement initiate_liquidity_retrival tests keep-starknet-strange#84
0xChqrles added a commit that referenced this issue Sep 27, 2024
* test(revolut_test): added initiate_liquidity_retrieval tests

 [CONTRACTS] implement initiate_liquidity_retrival tests #84

* various fix

---------

Co-authored-by: Chqrles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants