Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACTS] implement retrieve_liquidity tests #85

Closed
0xChqrles opened this issue Sep 23, 2024 · 10 comments
Closed

[CONTRACTS] implement retrieve_liquidity tests #85

0xChqrles opened this issue Sep 23, 2024 · 10 comments
Assignees
Milestone

Comments

@0xChqrles
Copy link
Contributor

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

These tests are also related to #84

@chachaleo
Copy link
Contributor

can I work on this ? :)

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @chachaleo!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 23, 2024

I would love for work on this @0xChqrles

@Iwueseiter
Copy link

Hi @0xChqrles can I tackle this task?

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Iwueseiter!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@ScottyDavies
Copy link

Hi @0xChqrles can i please be assigned this task?

@thesledge04
Copy link

hey @0xChqrles can i be assigned this task?

Copy link

onlydustapp bot commented Sep 26, 2024

Hey @ScottyDavies!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

Copy link

onlydustapp bot commented Sep 26, 2024

Hey @thesledge04!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@leohscl
Copy link
Contributor

leohscl commented Sep 30, 2024

I would like to get this one please

leohscl added a commit to leohscl/zkramp that referenced this issue Oct 1, 2024
CI is not passing because of a bug in the retrieve_liquidity function, liquidity amount is never updated

 [CONTRACTS] implement retrieve_liquidity tests keep-starknet-strange#85
leohscl added a commit to leohscl/zkramp that referenced this issue Oct 1, 2024
CI is not passing because of a bug in the retrieve_liquidity function, liquidity amount is never updated

 [CONTRACTS] implement retrieve_liquidity tests keep-starknet-strange#85
0xChqrles added a commit that referenced this issue Oct 1, 2024
* test(revolut_test): added tests for retrieve_liquidity

CI is not passing because of a bug in the retrieve_liquidity function, liquidity amount is never updated

 [CONTRACTS] implement retrieve_liquidity tests #85

* fix tests

---------

Co-authored-by: 0xChqrles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants