-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTRACTS] implement retrieve_liquidity
tests
#85
Comments
can I work on this ? :) |
Hey @chachaleo! |
I would love for work on this @0xChqrles |
Hi @0xChqrles can I tackle this task? |
Hey @Iwueseiter! |
Hi @0xChqrles can i please be assigned this task? |
hey @0xChqrles can i be assigned this task? |
Hey @ScottyDavies! |
Hey @thesledge04! |
I would like to get this one please |
CI is not passing because of a bug in the retrieve_liquidity function, liquidity amount is never updated [CONTRACTS] implement retrieve_liquidity tests keep-starknet-strange#85
CI is not passing because of a bug in the retrieve_liquidity function, liquidity amount is never updated [CONTRACTS] implement retrieve_liquidity tests keep-starknet-strange#85
* test(revolut_test): added tests for retrieve_liquidity CI is not passing because of a bug in the retrieve_liquidity function, liquidity amount is never updated [CONTRACTS] implement retrieve_liquidity tests #85 * fix tests --------- Co-authored-by: 0xChqrles <[email protected]>
The tests are already defined in
src/contracts/ramps/revolut/revolut_test.cairo
. You just need to write their implementation following the way the escrow tests are implemented.These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.
To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app
These tests are also related to #84
The text was updated successfully, but these errors were encountered: