Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACTS] implement initiate_liquidity_withdraw tests #86

Closed
0xChqrles opened this issue Sep 23, 2024 · 12 comments · Fixed by #97
Closed

[CONTRACTS] implement initiate_liquidity_withdraw tests #86

0xChqrles opened this issue Sep 23, 2024 · 12 comments · Fixed by #97
Assignees
Milestone

Comments

@0xChqrles
Copy link
Contributor

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

@mubarak23
Copy link
Contributor

mubarak23 commented Sep 23, 2024

@0xChqrles can i work on this ,
am available

I am a Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project

My recent work with cairo starknet

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @mubarak23!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Oshioke-Salaki
Copy link

Please can I handle this?

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Oshioke-Salaki!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@ikemHood
Copy link
Contributor

hello @0xChqrles , I would love to work on this

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @ikemHood!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@od-hunter
Copy link

Hi @0xChqrles , can I work on this please? Please

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @od-hunter!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Benjtalkshow
Copy link

Hello @0xChqrles ,
Can I be assigned to this? I can tackle this issue asap.

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Benjtalkshow!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@chachaleo
Copy link
Contributor

Can I work on this? :)

Copy link

onlydustapp bot commented Sep 26, 2024

Hey @chachaleo!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants