Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACTS] implement withdraw_liquidity tests #87

Closed
0xChqrles opened this issue Sep 23, 2024 · 9 comments · Fixed by #101
Closed

[CONTRACTS] implement withdraw_liquidity tests #87

0xChqrles opened this issue Sep 23, 2024 · 9 comments · Fixed by #101

Comments

@0xChqrles
Copy link
Contributor

implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

These tests are also related to #86

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 23, 2024

I would love to work on this testing @0xChqrles 😌

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Jemiiah!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Oshioke-Salaki
Copy link

Please can I do this?

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Oshioke-Salaki!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@ikemHood
Copy link
Contributor

Hello @0xChqrles , can i also do this one

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @ikemHood!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@thesledge04
Copy link

hello @0xChqrles can i be assigned this task?

Copy link

onlydustapp bot commented Sep 26, 2024

Hey @thesledge04!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@chachaleo
Copy link
Contributor

Can I work on this ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants