-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTRACTS] implement _get_next_timestamp_key
tests
#88
Comments
@0xChqrles i will like to work on this |
Hey @ShantelPeters! |
@0xChqrles am available to work on this. I am an Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust. i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project My recent work with cairo starknet
|
Hey @mubarak23! |
@0xChqrles I would love to work on this |
I would like to work on this, I have experience contributing to open source projects and also working on Cairo codes. https://github.com/keep-starknet-strange/raito/commits?author=bloomingpeach&since=2024-08-31&until=2024-09-23 |
Hey @bloomingpeach! |
Hello @0xChqrles , |
Hey @Benjtalkshow! |
@0xChqrles can I please be assigned to work on this? |
I'm up for this one @0xChqrles |
…tor of _get_next_timestamp_key function * added tests * changed _get_next_timestamp_key to return 0 on 0 input * _get_next_timestamp_key is more readable [CONTRACTS] implement _get_next_timestamp_key tests keep-starknet-strange#88
* test(revolut_test): Added _get_next_timestamp_key_tests, slight refactor of _get_next_timestamp_key function * added tests * changed _get_next_timestamp_key to return 0 on 0 input * _get_next_timestamp_key is more readable [CONTRACTS] implement _get_next_timestamp_key tests #88 * minor fix --------- Co-authored-by: 0xChqrles <[email protected]>
The tests are already defined in
src/contracts/ramps/revolut/revolut_test.cairo
. You just need to write their implementation following the way the escrow tests are implemented.These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.
To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app
The text was updated successfully, but these errors were encountered: