Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACTS] implement _get_next_timestamp_key tests #88

Open
0xChqrles opened this issue Sep 23, 2024 · 12 comments
Open

[CONTRACTS] implement _get_next_timestamp_key tests #88

0xChqrles opened this issue Sep 23, 2024 · 12 comments
Assignees
Milestone

Comments

@0xChqrles
Copy link
Contributor

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

@ShantelPeters
Copy link

@0xChqrles i will like to work on this

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @ShantelPeters!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@mubarak23
Copy link
Contributor

mubarak23 commented Sep 23, 2024

@0xChqrles am available to work on this.

I am an Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project

My recent work with cairo starknet

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @mubarak23!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 23, 2024

@0xChqrles I would love to work on this

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Jemiiah!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@bloomingpeach
Copy link

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @bloomingpeach!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Benjtalkshow
Copy link

Hello @0xChqrles ,
Can I be assigned to this? I can tackle this issue asap.

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Benjtalkshow!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Mystic-Nayy
Copy link

@0xChqrles can I please be assigned to work on this?

@leohscl
Copy link
Contributor

leohscl commented Oct 3, 2024

I'm up for this one @0xChqrles

leohscl added a commit to leohscl/zkramp that referenced this issue Oct 4, 2024
…tor of _get_next_timestamp_key function

* added tests

* changed _get_next_timestamp_key to return 0 on 0 input

* _get_next_timestamp_key is more readable

 [CONTRACTS] implement _get_next_timestamp_key tests keep-starknet-strange#88
0xChqrles added a commit that referenced this issue Oct 7, 2024
* test(revolut_test): Added _get_next_timestamp_key_tests, slight refactor of _get_next_timestamp_key function

* added tests

* changed _get_next_timestamp_key to return 0 on 0 input

* _get_next_timestamp_key is more readable

 [CONTRACTS] implement _get_next_timestamp_key tests #88

* minor fix

---------

Co-authored-by: 0xChqrles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants