Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONTRACTS] implement available_liquidity tests #89

Closed
0xChqrles opened this issue Sep 23, 2024 · 10 comments · Fixed by #106
Closed

[CONTRACTS] implement available_liquidity tests #89

0xChqrles opened this issue Sep 23, 2024 · 10 comments · Fixed by #106
Assignees
@leohscl
Labels
contracts testing
Milestone
Milestone 1

Comments

@0xChqrles
Copy link
Contributor

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app
@0xChqrles 0xChqrles added this to the Milestone 1 milestone Sep 23, 2024
@mubarak23
Copy link
Contributor

mubarak23 commented Sep 23, 2024 •
edited
Loading

@0xChqrles am available on this.

I am an Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project

My recent work with cairo starknet

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 23, 2024 •
edited
Loading

I would love to work on this testing @0xChqrles

@0xChqrles 0xChqrles mentioned this issue Sep 23, 2024
Closed
@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 23, 2024

Hey @mubarak23!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Jemiiah!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@manlikeHB
Copy link
Contributor

Can I work on this?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 23, 2024

Hey @manlikeHB!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Benjtalkshow
Copy link

Hello @0xChqrles ,
Can I be assigned to this? I can tackle this issue asap.

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Benjtalkshow!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@ScottyDavies
Copy link

@0xChqrles can i hop on this?

@leohscl
Copy link
Contributor

leohscl commented Oct 3, 2024

I'm up for this one @0xChqrles

leohscl added a commit to leohscl/zkramp that referenced this issue Oct 5, 2024
@leohscl
test(revolut_test): Added available_liquidity tests
9c18e8b 
Added tests for available liquidity. No bugs to report, everything seem to be working properly

 [CONTRACTS] implement available_liquidity tests keep-starknet-strange#89
leohscl added a commit to leohscl/zkramp that referenced this issue Oct 5, 2024
@leohscl
test(revolut_test): Added available_liquidity tests
a2695ae 
Added tests for available liquidity. No bugs to report, everything seem to be working properly

[CONTRACTS] implement available_liquidity tests keep-starknet-strange#89
leohscl added a commit to leohscl/zkramp that referenced this issue Oct 5, 2024
@leohscl
test(revolut_test): Added available_liquidity tests
2b818c3 
Added tests for available liquidity. No bugs to report, everything seem to be working properly

[CONTRACTS] implement available_liquidity tests keep-starknet-strange#89
leohscl added a commit to leohscl/zkramp that referenced this issue Oct 5, 2024
@leohscl
test(revolut_test): Added available_liquidity tests
72ccea4 
Added tests for available liquidity. No bugs to report, everything seem to be working properly

[CONTRACTS] implement available_liquidity tests keep-starknet-strange#89
leohscl added a commit to leohscl/zkramp that referenced this issue Oct 5, 2024
@leohscl
test(revolut_test): Added available_liquidity tests
c253959 
Added tests for available liquidity. No bugs to report, everything seem to be working properly

[CONTRACTS] implement available_liquidity tests keep-starknet-strange#89
@leohscl leohscl mentioned this issue Oct 5, 2024
Merged
0xChqrles added a commit that referenced this issue Oct 7, 2024
@leohscl @0xChqrles
test(revolut_test): Added available_liquidity tests (#106)
9cfc69b 
* test(revolut_test): Added available_liquidity tests

Added tests for available liquidity. No bugs to report, everything seem to be working properly

[CONTRACTS] implement available_liquidity tests #89

* minor fix

---------

Co-authored-by: Chqrles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leohscl leohscl

Labels
contracts testing
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging a pull request may close this issue.

test(revolut_test): Added available_liquidity tests leohscl/zkramp
7 participants
@mubarak23 @0xChqrles @Benjtalkshow @leohscl @manlikeHB @Jemiiah @ScottyDavies