Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improvements in helm chart #18

Merged
merged 4 commits into from
Apr 3, 2024
Merged

feat: Improvements in helm chart #18

merged 4 commits into from
Apr 3, 2024

Conversation

rvgud
Copy link
Contributor

@rvgud rvgud commented Apr 3, 2024

📑 Description

Improves overall helm chart, adding options to add extra volumes, options to disable pv or pvc, options to add health probes

@rvgud rvgud requested a review from talboren as a code owner April 3, 2024 09:49
@rvgud rvgud changed the title Improvements in helm chart feat-Improvements in helm chart Apr 3, 2024
@rvgud rvgud changed the title feat-Improvements in helm chart feat: Improvements in helm chart Apr 3, 2024
Copy link
Contributor

@pehlicd pehlicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also run pre-commit run -a for updating helm doc

charts/keep/values.yaml Outdated Show resolved Hide resolved
charts/keep/values.yaml Show resolved Hide resolved
Copy link
Contributor

@pehlicd pehlicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahargl shahargl merged commit ea178cd into keephq:main Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants