Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add keep-component label to deployments #23

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: add keep-component label to deployments #23

merged 2 commits into from
Aug 5, 2024

Conversation

ztzxt
Copy link
Contributor

@ztzxt ztzxt commented Aug 5, 2024

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@ztzxt ztzxt requested a review from talboren as a code owner August 5, 2024 11:57
shahargl
shahargl approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shahargl shahargl merged commit e2425fc into keephq:main Aug 5, 2024
4 checks passed
@ztzxt ztzxt deleted the adjust-deployment-label-selector branch August 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl approved these changes

@talboren talboren Awaiting requested review from talboren talboren is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ztzxt @shahargl