fix: posthog to None if disabled (#2989)

keephq · Jan 6, 2025 · 84aa526 · 84aa526
1 parent ee49e7c
commit 84aa526
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 16 deletions.
diff --git a/keep/api/core/posthog.py b/keep/api/core/posthog.py
@@ -16,17 +16,19 @@
 
 POSTHOG_DISABLED = os.getenv("POSTHOG_DISABLED", "false").lower() == "true"
 
-if POSTHOG_DISABLED:
-    posthog.disabled = True
-
 POSTHOG_API_KEY = (
     os.getenv("POSTHOG_API_KEY")
     or "phc_muk9qE3TfZsX3SZ9XxX52kCGJBclrjhkP9JxAQcm1PZ"  # It's a public PH API key, not a leaked secret ;)
 )
-posthog_client = Posthog(
-    api_key=POSTHOG_API_KEY, 
-    host="https://app.posthog.com", 
-)
+
+if POSTHOG_DISABLED:
+    posthog.disabled = True
+    posthog_client = None
+else:
+    posthog_client = Posthog(
+        api_key=POSTHOG_API_KEY, 
+        host="https://app.posthog.com", 
+    )
 
 
 def is_posthog_reachable():

diff --git a/keep/cli/cli.py b/keep/cli/cli.py
@@ -187,14 +187,15 @@ def cli(ctx, info: Info, verbose: int, json: bool, keep_config: str):
     # https://posthog.com/tutorials/identifying-users-guide#identifying-and-setting-user-ids-for-every-other-library
     # random user id
     info.set_config(keep_config)
-    posthog_client.capture(
-        info.random_user_id,
-        "keep-cli-started",
-        properties={
-            "args": sys.argv,
-            "keep_version": KEEP_VERSION,
-        },
-    )
+    if posthog_client is not None:
+        posthog_client.capture(
+            info.random_user_id,
+            "keep-cli-started",
+            properties={
+                "args": sys.argv,
+                "keep_version": KEEP_VERSION,
+            },
+        )
     # Use the verbosity count to determine the logging level...
     if verbose > 0:
         # set the verbosity level to debug
@@ -208,7 +209,7 @@ def cli(ctx, info: Info, verbose: int, json: bool, keep_config: str):
 
     @ctx.call_on_close
     def cleanup():
-        if posthog_client:
+        if posthog_client is not None:
             posthog_client.flush()