Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential updating of test suite #40

Open
barefootcoder opened this issue Apr 10, 2015 · 2 comments
Open

Potential updating of test suite #40

barefootcoder opened this issue Apr 10, 2015 · 2 comments

Comments

@barefootcoder
Copy link

So, I was working on a module that wants to be compatible with Path::Class. So I thought it made sense that it should pass most (if not all) of Path::Class's unit tests. So I stole 'em. :-D

But, as I was working with them, I started to notice that they really old. Like, super old. Like, pre-Test::More old. And, the more I worked with them, the more I kept tweaking them to be more modern, because that made it easier to find my failures.

So, at some point, it occurred to me: maybe I should share this modernization back with the original module. So, here I am offering to do so. :-)

Specifically, I would:

  • change use Test to use Test::More;
  • change all the two-argument ok calls to is calls
  • change things such as ok $cat->isa('Path::Class::File') to isa_ok($cat, 'Path::Class::File')
  • add test names for most (if not all) tests
  • anything else I come across that looks in dire need of updating :-)

Is this something you'd be interested in? If so, I'll hold off on my test updating and just update everything in situ, give you a pull request, then I can steal the updated tests for my module. Or, if you don't want this sort of update, I'll happily just keep going in my own little world and not bother you further. :-)

Let me know! And thx for all you do for Perl.

@ghost
Copy link

ghost commented Apr 10, 2015

Sure, sounds great! Thanks for the offer.

@barefootcoder
Copy link
Author

Okay, I've forked. No promises on when I'll be able to finish it, but I'll keep plugging away at it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant