Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report array query params problem. #1

Open
dokansig opened this issue Apr 5, 2019 · 4 comments
Open

report array query params problem. #1

dokansig opened this issue Apr 5, 2019 · 4 comments

Comments

@dokansig
Copy link

dokansig commented Apr 5, 2019

The following cases to safe.
?queryparam[a][b]=value

add this code please.
if (typeof val === "object") return;

I tried to pull request but it did not work well.
if possible. Please be corresponding.
thank you.

@kentdotn
Copy link
Owner

Thank you for reporting the problem.
Could you elaborate what happens when you send the pull request so that I would fix the settings of this repository?
I think it's better to merge your code rather than just copy-and-paste it by me.

@dokansig
Copy link
Author

Thank you for your reply.
The following error is displayed.

remote: Permission to kentdotn/comma-separated-query-param.git denied to dokansig.
fatal: unable to access 'https://github.com/kentdotn/comma-separated-query-param.git/': The requested URL returned error: 403

@kentdotn
Copy link
Owner

Thank you for your information.
OK, I understood what's going on.
You are trying to push your code to my repository directly. However, I didn't add you in Collaborators of this repo, so your access is denied.

Could you try following steps?

  1. Fork this repo to your Github organization (just push the "Fork" button on right-top of this page)
  2. Create a branch on your own forked repo and push your code into the branch
  3. Make Pull Request from your branch to my master branch

@dokansig
Copy link
Author

dokansig commented May 9, 2019

Thank you for the advice.
I tried the indicated procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants