-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace image with local image links #228
Merged
nehagup
merged 2 commits into
keploy:main
from
AkashKumar7902:docs-replace-image-with-local-links
Oct 4, 2023
Merged
docs: replace image with local image links #228
nehagup
merged 2 commits into
keploy:main
from
AkashKumar7902:docs-replace-image-with-local-links
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akash Kumar <[email protected]>
do you want the logo in docs.keploy.io/docs/server to also be rendered from img/os/* ? |
@AkashKumar7902 yes all the images related to OS should be rendered from local images. |
Signed-off-by: Akash Kumar <[email protected]>
hey @nehagup can you please review it ? |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
* docs: replace image with local image links Signed-off-by: Akash Kumar <[email protected]> * docs: replace image links with img/os/* Signed-off-by: Akash Kumar <[email protected]> --------- Signed-off-by: Akash Kumar <[email protected]>
swatichauhan814
pushed a commit
to swatichauhan814/docs
that referenced
this pull request
Oct 7, 2023
* docs: replace image with local image links Signed-off-by: Akash Kumar <[email protected]> * docs: replace image links with img/os/* Signed-off-by: Akash Kumar <[email protected]> --------- Signed-off-by: Akash Kumar <[email protected]> Signed-off-by: schauhan2 <[email protected]>
swatichauhan814
pushed a commit
to swatichauhan814/docs
that referenced
this pull request
Oct 7, 2023
* docs: replace image with local image links Signed-off-by: Akash Kumar <[email protected]> * docs: replace image links with img/os/* Signed-off-by: Akash Kumar <[email protected]> --------- Signed-off-by: Akash Kumar <[email protected]> Signed-off-by: schauhan2 <[email protected]>
swatichauhan814
pushed a commit
to swatichauhan814/docs
that referenced
this pull request
Oct 7, 2023
* docs: replace image with local image links Signed-off-by: Akash Kumar <[email protected]> * docs: replace image links with img/os/* Signed-off-by: Akash Kumar <[email protected]> --------- Signed-off-by: Akash Kumar <[email protected]> Signed-off-by: schauhan2 <[email protected]>
swatichauhan814
pushed a commit
to swatichauhan814/docs
that referenced
this pull request
Oct 7, 2023
* docs: replace image with local image links Signed-off-by: Akash Kumar <[email protected]> * docs: replace image links with img/os/* Signed-off-by: Akash Kumar <[email protected]> --------- Signed-off-by: Akash Kumar <[email protected]> Signed-off-by: schauhan2 <[email protected]>
swatichauhan814
pushed a commit
to swatichauhan814/docs
that referenced
this pull request
Oct 7, 2023
* docs: replace image with local image links Signed-off-by: Akash Kumar <[email protected]> * docs: replace image links with img/os/* Signed-off-by: Akash Kumar <[email protected]> --------- Signed-off-by: Akash Kumar <[email protected]> Signed-off-by: schauhan2 <[email protected]>
swatichauhan814
pushed a commit
to swatichauhan814/docs
that referenced
this pull request
Oct 7, 2023
* docs: replace image with local image links Signed-off-by: Akash Kumar <[email protected]> * docs: replace image links with img/os/* Signed-off-by: Akash Kumar <[email protected]> --------- Signed-off-by: Akash Kumar <[email protected]> Signed-off-by: schauhan2 <[email protected]>
swatichauhan814
pushed a commit
to swatichauhan814/docs
that referenced
this pull request
Oct 7, 2023
* docs: replace image with local image links Signed-off-by: Akash Kumar <[email protected]> * docs: replace image links with img/os/* Signed-off-by: Akash Kumar <[email protected]> --------- Signed-off-by: Akash Kumar <[email protected]> Signed-off-by: schauhan2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (keploy/keploy#877)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: