Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace image with local image links #228

Merged

Conversation

AkashKumar7902
Copy link
Contributor

Pull Request Template

Description

Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (keploy/keploy#877)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

@AkashKumar7902
Copy link
Contributor Author

do you want the logo in docs.keploy.io/docs/server to also be rendered from img/os/* ?

@nehagup
Copy link
Member

nehagup commented Sep 30, 2023

@AkashKumar7902 yes all the images related to OS should be rendered from local images.

@AkashKumar7902
Copy link
Contributor Author

hey @nehagup can you please review it ?

@nehagup nehagup merged commit 61a33b6 into keploy:main Oct 4, 2023
4 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
* docs: replace image with local image links

Signed-off-by: Akash Kumar <[email protected]>

* docs: replace image links with img/os/*

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* docs: replace image with local image links

Signed-off-by: Akash Kumar <[email protected]>

* docs: replace image links with img/os/*

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* docs: replace image with local image links

Signed-off-by: Akash Kumar <[email protected]>

* docs: replace image links with img/os/*

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* docs: replace image with local image links

Signed-off-by: Akash Kumar <[email protected]>

* docs: replace image links with img/os/*

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* docs: replace image with local image links

Signed-off-by: Akash Kumar <[email protected]>

* docs: replace image links with img/os/*

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* docs: replace image with local image links

Signed-off-by: Akash Kumar <[email protected]>

* docs: replace image links with img/os/*

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* docs: replace image with local image links

Signed-off-by: Akash Kumar <[email protected]>

* docs: replace image links with img/os/*

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* docs: replace image with local image links

Signed-off-by: Akash Kumar <[email protected]>

* docs: replace image links with img/os/*

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants