-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes faulty URLs #236
Fixes faulty URLs #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
…ncepts/what-are-keploy-features/ Signed-off-by: jailbreakerVC <[email protected]>
Signed-off-by: jailbreakerVC <[email protected]>
@nehagup Hi, is the lockfile supposed to be committed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jailbreakerVC !
There's a breaking link on http://localhost:3000/docs/1.0.0/concepts/what-are-keploy-features/ - check the last link of the page with "contribution guide."
If there's no package change then it's preferred not to commit the lock file. |
Thanks, @nehagup. I will look into it. Should I do anything about the Lint Codebase check that's failing? I'll take of it next time. |
You can give your best shot to resolve it, otherwise I'll merge |
Signed-off-by: VIJIT CHANDNA <[email protected]>
Pull Request Template
Description
Fixes faulty URLs
Fixes keploy/keploy#973
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
No tests as of now.
Checklist: