Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes faulty URLs #236

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Fixes faulty URLs #236

merged 4 commits into from
Oct 25, 2023

Conversation

jailbreakerVC
Copy link
Contributor

@jailbreakerVC jailbreakerVC commented Oct 7, 2023

Pull Request Template

Description

Fixes faulty URLs

Fixes keploy/keploy#973

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

How Has This Been Tested?

No tests as of now.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@jailbreakerVC
Copy link
Contributor Author

@nehagup Hi, is the lockfile supposed to be committed?

@jailbreakerVC jailbreakerVC changed the title fixes #973 Fixes faulty URLs Oct 7, 2023
@jailbreakerVC jailbreakerVC marked this pull request as ready for review October 7, 2023 13:37
Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jailbreakerVC !

There's a breaking link on http://localhost:3000/docs/1.0.0/concepts/what-are-keploy-features/ - check the last link of the page with "contribution guide."

@nehagup
Copy link
Member

nehagup commented Oct 9, 2023

@nehagup Hi, is the lockfile supposed to be committed?

If there's no package change then it's preferred not to commit the lock file.

@jailbreakerVC
Copy link
Contributor Author

jailbreakerVC commented Oct 9, 2023

Thanks, @nehagup. I will look into it. Should I do anything about the Lint Codebase check that's failing? I'll take of it next time.

@nehagup
Copy link
Member

nehagup commented Oct 10, 2023

Thanks, @nehagup. I will look into it. Should I do anything about the Lint Codebase check that's failing? I'll take of it next time.

You can give your best shot to resolve it, otherwise I'll merge

@PranshuSrivastava PranshuSrivastava merged commit 423f55d into keploy:main Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: fix broken urls
3 participants