You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When prototyping our model API in PR #288 we were following the example of keras-cv. They have DenseNet and DenseNet121 and we have Bert and BertBase. Unfortunately the convention of naming an architecture "base" in NLP makes these names confusing so @mattdangerw and I have discussed changing models.Bert() to models.BertCustom() for clarity.
I think "custom" is a reasonable modifier to indicate that BertCustom is customizable in contrast to BertBase and upcoming arches like BertLarge. Thoughts?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
When prototyping our model API in PR #288 we were following the example of
keras-cv
. They haveDenseNet
andDenseNet121
and we haveBert
andBertBase
. Unfortunately the convention of naming an architecture "base" in NLP makes these names confusing so @mattdangerw and I have discussed changingmodels.Bert()
tomodels.BertCustom()
for clarity.I think "custom" is a reasonable modifier to indicate that
BertCustom
is customizable in contrast toBertBase
and upcoming arches likeBertLarge
. Thoughts?Beta Was this translation helpful? Give feedback.
All reactions