Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go over examples #34

Open
2 tasks
abheesht17 opened this issue Feb 25, 2025 · 0 comments
Open
2 tasks

Go over examples #34

abheesht17 opened this issue Feb 25, 2025 · 0 comments

Comments

@abheesht17
Copy link
Collaborator

abheesht17 commented Feb 25, 2025 •
edited
Loading

There are a few things we need to look into for examples.

  • For the GRU4Rec example, we need to figure out if no loss reduction is the right way to do it (instead of sum_over_batch_size). The loss does not converge for the latter, whereas it does for the former. TFRS does no reduction.
  • Consider shifting back to a subclassed model for DCN (rather than Functional).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abheesht17