Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masking support in BatchNorm #18759

Closed
3lim opened this issue Nov 10, 2023 · 4 comments
Closed

Masking support in BatchNorm #18759

3lim opened this issue Nov 10, 2023 · 4 comments
Assignees
@sachinprasadhs
Labels
stale stat:awaiting response from contributor type:feature The user is asking for a new feature.

Comments

@3lim
Copy link
Contributor

3lim commented Nov 10, 2023

Keras2 supports masking in its BatchNorm implementation. While Keras3 seems to accept a "mask" param, is it not used anywhere. This seems inconsistent.
@sachinprasadhs sachinprasadhs added type:Bug keras-team-review-pending Pending review by a Keras team member. labels Nov 10, 2023
@fchollet
Copy link
Collaborator

Indeed, we should add masking support in the BatchNormalization layer. Is this something you'd be able to open a PR for?

@sachinprasadhs sachinprasadhs removed the keras-team-review-pending Pending review by a Keras team member. label Nov 13, 2023
@TomCoded TomCoded mentioned this issue Dec 10, 2023
Merged
@sachinprasadhs sachinprasadhs added type:feature The user is asking for a new feature. and removed type:Bug labels May 15, 2024
@sachinprasadhs
Copy link
Collaborator

We can close this issue since masking is now supported in BatchNormalization here https://keras.io/api/layers/normalization_layers/batch_normalization/

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label May 30, 2024
@github-actions GitHub Actions
Copy link

This issue was closed because it has been inactive for 28 days. Please reopen if you'd like to work on this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sachinprasadhs sachinprasadhs

Labels
stale stat:awaiting response from contributor type:feature The user is asking for a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fchollet @3lim @sachinprasadhs